search

flant / addon-operator

A system to manage additional components for Kubernetes cluster in a simple, consistent and automated way.
https://flant.github.io/addon-operator/
Apache License 2.0
483 stars 27 forks source link

Added logs before os.Exit(1) in main.go #446

Closed akaitux closed 9 months ago

akaitux commented 9 months ago

Overview

Added logs before os.Exit(1) with error in main.go

What this PR does / why we need it

If you use the operator as is and do not add the /global-hooks directory to the image, the code exits with exit code 1 without any error messages.

Special notes for your reviewer

diafour commented 9 months ago

Oops you've broken JSON logging =) fmt.Printf should be replaced with log.Error.

akaitux commented 9 months ago

@diafour Sorry, I specifically made an issue so that someone from the team would add these changes, since I don’t know the entire infrastructure. Should I make another pr or will you fix it yourself?

nabokihms commented 9 months ago

This is not a problem, because this is the first error.