flapdoodle-oss / de.flapdoodle.embed.mongo.spring

embedded mongo spring integration
Apache License 2.0
32 stars 7 forks source link

Could not download embedded mongo cause URL mismatch #46

Closed fightForPG closed 6 months ago

fightForPG commented 8 months ago

My local Env: JDK 17 Kotlin 1.8.21 Springboot 3.2.1 de.flapdoodle.embed:de.flapdoodle.embed.mongo.spring30x:4.11.0

config: de: flapdoodle: mongodb: embedded: version: 5.0.18

We tried to load the 5.0.18 from our local maven artifact repo server like: "https://{username}:{password}@artifactrepository.mydomain/mongo"

We tested the "above url + zip file name" and could download the zip file "https://{username}:{password}@artifactrepository.mydomain/mongo/window/mongodb-windows-x86_64-5.0.18.zip"

And we customized the mongod download url with this guide: https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/blob/main/docs/Customizations.md#customize-download-url

Mongod mongod = new Mongod() { @Override public Transition distributionBaseUrl() { return Start.to(DistributionBaseUrl.class) .initializedWith(DistributionBaseUrl.of("https://{username}:{password}@artifactrepository.mydomain/mongo")); } };

But we keep getting this error: error log: parts missing: 'https://{username}:{password}@artifactrepository.mydomain/mongo/window/mongodb-windows-x86_64-5.0.18.zip' != 'https://artifactrepository.mydomain' + '/mongo/window/mongodb-windows-x86_64-5.0.18.zip'

checked the code: String serverPart = serverPart(url) String pathPart = pathpart(url) Preconditions.checkArgument(url.toString().equals(serverPart + pathPart), "parts missing: '%s' != '%s' + '%s'", new Object[]{ url, serverPart, pathPart})

Seems the code checks the URL without the auth, how to fix this?

michaelmosmann commented 8 months ago

@fightForPG ah.. made a bugfix in this location yesterday.. hmm.. I think you can not fix this by yourself.. i have to make some changes.. i think i can create a new release in the evening.

fightForPG commented 8 months ago

Thank you so much for so quick fix, looking forwards to the new release~

michaelmosmann commented 8 months ago

@fightForPG .. release done, should be in maven central in some hours:)

fightForPG commented 8 months ago

Hi, @michaelmosmann I checked with maven repository and found the version is still the old one.

michaelmosmann commented 8 months ago

@fightForPG it should be there: https://repo1.maven.org/maven2/de/flapdoodle/embed/de.flapdoodle.embed.mongo.spring3x/4.12.2/ repo browser are not always up to date..

fightForPG commented 6 months ago

Hi, @michaelmosmann https://mvnrepository.com/artifact/de.flapdoodle.embed/de.flapdoodle.embed.mongo.spring3x/4.12.2 The latest version has been updated to repo browser. Thank you!

michaelmosmann commented 6 months ago

i close this issue.. reopen if needed..