flapdoodle-oss / de.flapdoodle.os

os detection library
Apache License 2.0
5 stars 11 forks source link

Split package de.flapdoodle.os #18

Open yeefan opened 4 months ago

yeefan commented 4 months ago

OS Detection Library depends on OS Detection Library API, and both projects contain a common package de.flapdoodle.os resulting in it being a split package.

This means that OS Detection Library cannot be used in a modular Java application, unless some workaround is applied, e.g., merging OS Detection Library and OS Detection Library API into a fat jar.

michaelmosmann commented 4 months ago

@yeefan so you are using this library for other stuff than tests?

yeefan commented 4 months ago

I found this issue when I added unit tests using embed-mongo into an existing project that happened to use the java-modularity Gradle plugin, so by default modularity was also applied to tests. I was able to workaround by turning off modularity for tests. However, I thought that OS Detection Library is pretty generic, so I opened this issue for your consideration.

michaelmosmann commented 4 months ago

@yeefan ah.. is see. I will think about that .. :)