Closed ghost closed 10 years ago
Looks good.
The CGI
and URI
modules in Ruby are dark, confusing places.
Merge away.
It's unfortunate about the : needing to be URI escaped but otherwise all good, :+1:
Yeah, webmock
will work with encoded or non-encoded strings (and is more liberal than sinatra
in that respect) but I wanted to change the expectations to match the exact encodings we want to send.
If we don't have a specific need to encode colons in the uris I'd rather not do it for readability of web server logs, intercepting traffic etc.
They won't be encoded in the paths, so maybe I should change the tests back :frowning: They will be encoded in parameters though (e.g. ISO8601 time strings).
Fixes #28.
The RFC says that commas are reserved characters too (and should thus be escaped), but URI.escape doesn't do that. Leaving for now as it's not causing problems in Flapjack.