Closed ghicks-rmn closed 10 years ago
No need to split, thanks for pointing these out.
1) is sort of vestigial from pre 1.0 days, the current code would work better with creating the contact and then creating the media as a second operation using create_contact_media
.
2) The README in master references the latest code, which may contain unreleased stuff; quite a bit of the tag handling has seen work recently in Flapjack proper and here, I'll check to make sure that they're consistent and also try to make sure we release a new version of diner for the next Flapjack release, which should be soon.
3) is the result of excessive copy & paste, will fix.
I also need to change the docs for all create_*
functions to point out that they now return the generated IDs.
Hi, let me know if I should split these into separate issues.