search

flapjack / flapjack-diner

Consumer of the Flapjack API
http://flapjack.io/
MIT License
17 stars 10 forks source link

Creating PagerDuty credentials requires user/pass/subdomain #39

Closed ghicks-rmn closed 9 years ago

ghicks-rmn commented 9 years ago

I'm trying to use flapjack-diner to create PagerDuty credentials, but it's failing to submit the request whenever I don't pass a username, password, or subdomain.

None of these is actually required for PagerDuty access - I tested by submitting only a service key to Flapjack using a curl call, and it was able to push alerts.

ghicks-rmn commented 9 years ago

Closing issue - after further testing the actual problem was that the docs were incorrect about how to make the call. I will open a different issue for that problem.

ghicks-rmn commented 9 years ago

Argh. I forgot that I worked around this in my interface by putting empty strings as defaults - it is in fact broken in Diner.

Also, the "create" action takes an ARRAY of hashes in 1.0, but the docs say just a hash. I'm not sure if this has been changed since then, but an array of hashes doesn't make sense anyway because Flapjack allows only one set of Pagerduty credentials for each contact.

ghost commented 9 years ago

I think the intention was to allow either a hash or an array of hashes for any of the create actions, I need to check whether that was actually realised or all of them only take an array of hashes, and either fix the code or the documentation. I'll try to get to this today.

ghost commented 9 years ago

Addressed in the PR above, new version of the gem should be released alongside Flapjack v1.2.0, which should be quite soon (we're just doing some final testing this week).