flapjack / flapjack-diner

Consumer of the Flapjack API
http://flapjack.io/
MIT License
17 stars 10 forks source link

Change create arg parsing, relax PagerDuty credentials validation #40

Closed ghost closed 9 years ago

ghost commented 9 years ago

See #39 for the reasons for the create args change; the docs were correct, the code was slightly deficient.

Also removed some duplicated code left over from recent refactoring.

Sarah-E-Greene commented 9 years ago

Looks fine to me.

jessereynolds commented 9 years ago

is this good to go into a 1.2.0 diner release at the same time as flapjack 1.2 ?

ghost commented 9 years ago

Yup, should be fine. A slight expansion in capabilities, it now matches what I'd thought it was doing when I wrote the docs.