Notification Rule Time Restrictions Can't be Updated

[skorfmann]

Input from our app into FlapjackDiner#update_notification_rules

id: "3eb72c3a-76d7-412a-ad0e-29e9a90d2c70"

attributes:

{"tags"=>nil,
 "regex_tags"=>nil,
 "entities"=>["some-entity-id"],
 "regex_entities"=>nil,
 "time_restrictions"=>
  [{"end_time"=>"2014-10-28 00:00:00",
    "rrules"=>[{"validations"=>{"day"=>[1, 2, 5, 6, 0]}, "rule_type"=>"Weekly", "interval"=>1, "week_start"=>0}],
    "exrules"=>[],
    "rtimes"=>[],
    "extimes"=>[],
    "summary"=>"Weekly on Sundays, Mondays, Tuesdays, Fridays, and Saturdays",
    "start_time"=>"2014-10-27 00:00:00"}],
 "unknown_media"=>nil,
 "warning_media"=>["email", "sms"],
 "critical_media"=>["email"],
 "unknown_blackhole"=>false,
 "warning_blackhole"=>false,
 "critical_blackhole"=>false,
 "links"=>{"contacts"=>[""]},
 "entity_tags"=>[]}

Flapjack Diner log

PATCH http://flapjack-server-example.org/notification_rules/3eb72c3a-76d7-412a-ad0e-29e9a90d2c70

[
    {
        : op=>"replace",
        : path=>"/notification_rules/0/tags",
        : value=>nil
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/regex_tags",
        : value=>nil
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/entities",
        : value=>[
            "some-entity-id"
        ]
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/regex_entities",
        : value=>nil
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/unknown_media",
        : value=>nil
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/warning_media",
        : value=>[
            "email",
            "sms"
        ]
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/critical_media",
        : value=>[
            "email"
        ]
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/unknown_blackhole",
        : value=>false
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/warning_blackhole",
        : value=>false
    },
    {
        : op=>"replace",
        : path=>"/notification_rules/0/critical_blackhole",
        : value=>false
    }
]

It looks like that time_restrictions is skipped in FlapjackDiner

[jessereynolds]

Awesome