search

flapjack / flapjack-diner

Consumer of the Flapjack API
http://flapjack.io/
MIT License
17 stars 10 forks source link

pagerduty_credentials to use token instead of username/password #54

Closed alperkokmen closed 9 years ago

alperkokmen commented 9 years ago

on June 16, 2014, PagerDuty announced that Basic Authentication was being deprecated.

these changes remove using username and password for communicating with PagerDuty REST API in favor of token. more details about how PagerDuty API authentication works can be found here.

here is the related pull request for flapjack itself: https://github.com/flapjack/flapjack/pull/831.

note: flapjack-diner-flapjack.json was also modified after i ran the tests; i am guessing it's an auto-generated file.

ghost commented 9 years ago

note: flapjack-diner-flapjack.json was also modified after i ran the tests; i am guessing it's an auto-generated file.

Yes, it's autogenerated by pact (and copied into the main Flapjack folder structure manually as appropriate, but the flapjack PR has made changes to the file that should be equivalent to the changes here).

Merging now for parity with https://github.com/flapjack/flapjack/pull/831 , I'll fix in the v2_pre branch(es) when the corresponding work is done in flapjack master.

ghost commented 9 years ago

Thanks!