search

flapjack / flapjack

Monitoring notification routing + event processing system. For issues with the Flapjack packages, please see https://github.com/flapjack/omnibus-flapjack/
http://flapjack.io
MIT License
639 stars 92 forks source link

use zermelo locking for pagerduty AckFinder semaphore #861

Open jessereynolds opened 9 years ago

jessereynolds commented 9 years ago

@ali-graham says:

we could maybe use that class directly to set up something safer, with an appropriate timeout (it should release the lock even on exception, but nothing's going to protect against, e.g. kill -9)).

He's referring to https://github.com/flapjack/zermelo/blob/master/lib/zermelo/locks/redis_lock.rb

See also: https://github.com/flapjack/flapjack/pull/856#discussion_r30107317

ghost commented 9 years ago

Locking in zermelo isn't abstracted properly yet to be backend-independent, but, you know, small steps and all that.