search

flapjack / flapjackfeeder

Nagios/Icinga event broker module (neb), inserts events to Flapjack's Redis queue
GNU General Public License v2.0
8 stars 5 forks source link

Employ make or other appropriate build tool #9

Closed jessereynolds closed 9 years ago

jessereynolds commented 9 years ago

So we can build by just running 'make'. I'm not sure how best to handle downloading of the redis library and any other dependencies.

We can also then have travis automatically building flapjackfeeder and telling us about any compilation errors.

We might even like to add some tests :-)

jessereynolds commented 9 years ago

Travis recommend using

http://docs.travis-ci.com/user/languages/c/

bs-github commented 9 years ago

see pull request https://github.com/flapjack/flapjackfeeder/pull/13 Maybe having a git submodule would be better than cloning the hiredis git repo from the Makefile, but it works how it's done now. https://github.com/flapjack/flapjackfeeder/blob/ecaaf4f4200783d9304ddcdde6d3027475fbc7fe/Makefile#L31-L34

Sarah-E-Greene commented 9 years ago

I'm fine with cloning it - we're already doing this in omnibus-flapjack.

bs-github commented 9 years ago

merged.