search

flapjack / omnibus-flapjack

Flapjack packages for all! Build the packages, and update the repositories.
http://flapjack.io
23 stars 14 forks source link

Recommend Rakefile usage in README #67

Closed Sarah-E-Greene closed 9 years ago

Sarah-E-Greene commented 9 years ago

The Rakefile makes building omnibus-flapjack a lot easier - the README should be tweaked to indicate that this is the case.

The env variables to set for the non-rakefile version are unclear, and likely out of date.

Sarah-E-Greene commented 9 years ago

The non-rakefile version built a package, but this didn't install properly:


    Selecting previously unselected package flapjack.
    (Reading database ... 218110 files and directories currently installed.)
    Preparing to unpack flapjack_20141223~bedf1fa9c9-1_amd64.deb ...
    Unpacking flapjack (20141223~bedf1fa9c9-1) ...
    Setting up flapjack (20141223~bedf1fa9c9-1) ...
    Creating /etc/flapjack/flapjack_config.yaml
    cp: cannot stat ‘/opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-2.0.0a1/etc/flapjack_config.yaml.example’: No such file or directory
    Creating /usr/local/lib/flapjackfeeder.o
    Creating /etc/init.d/redis-flapjack
    Creating /etc/init.d/flapjack
    Creating /etc/init.d/flapjack-nagios-receiver
    Creating /etc/init.d/flapper
    Setting paths
    Starting redis-flapjack
    Starting redis-server: redis-server.
    Starting flapjack
    /opt/flapjack/embedded/lib/ruby/site_ruby/2.1.0/rubygems/custom_require.rb:36:in `require': cannot load such file -- sandstorm/records/redis_record (LoadError)
            from /opt/flapjack/embedded/lib/ruby/site_ruby/2.1.0/rubygems/custom_require.rb:36:in `require'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-2.0.0a1/lib/flapjack/data/contact.rb:9:in `<top (required)>'
            from /opt/flapjack/embedded/lib/ruby/site_ruby/2.1.0/rubygems/custom_require.rb:36:in `require'
            from /opt/flapjack/embedded/lib/ruby/site_ruby/2.1.0/rubygems/custom_require.rb:36:in `require'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-2.0.0a1/lib/flapjack/cli/import.rb:6:in `<top (required)>'
            from /opt/flapjack/embedded/lib/ruby/site_ruby/2.1.0/rubygems/custom_require.rb:36:in `require'
            from /opt/flapjack/embedded/lib/ruby/site_ruby/2.1.0/rubygems/custom_require.rb:36:in `require'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/gli-2.12.0/lib/gli/app.rb:308:in `block in load_commands'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/gli-2.12.0/lib/gli/app.rb:305:in `each'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/gli-2.12.0/lib/gli/app.rb:305:in `load_commands'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/gli-2.12.0/lib/gli/app.rb:38:in `block in commands_from'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/gli-2.12.0/lib/gli/app.rb:36:in `each'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/gli-2.12.0/lib/gli/app.rb:36:in `commands_from'
            from /opt/flapjack/embedded/lib/ruby/gems/2.1.0/gems/flapjack-2.0.0a1/bin/flapjack:8:in `<top (required)>'
            from /opt/flapjack/bin/flapjack:23:in `load'
            from /opt/flapjack/bin/flapjack:23:in `<main>'
    dpkg: error processing package flapjack (--install):
     subprocess installed post-installation script returned error exit status 1
    Errors were encountered while processing:
     flapjack
jessereynolds commented 9 years ago

Seems like it installs fine but doesn't run properly. Maybe a bug in flapjack rather than the package?

jessereynolds commented 9 years ago

The above exception is being tracked here: https://github.com/flapjack/flapjack/issues/757

Sarah-E-Greene commented 9 years ago

Given the number of variables we're passing through, i'm in favour of declaring that the params passed to omnibus are an implementation detail, and not adding it to the readme. If someone actually wants to do a non-docker build, they can run the dry-run version, and copy/paste the commands.

That latter sentence should perhaps be documented.