DRY code by adding docker method

flapjack / omnibus-flapjack

Flapjack packages for all! Build the packages, and update the repositories.

http://flapjack.io

23 stars 14 forks source link

DRY code by adding docker method #85

Closed Sarah-E-Greene closed 9 years ago

jessereynolds commented 9 years ago

Funny, I have a similar branch locally. My approach is a bit different though:

moved the docker command invocation into OmnibusFlapjack::Docker
added spec tests for this, mocking Mixlib::ShellOut so we can test the logic without actually kicking off builds

I haven't gotten very far but will try and polish and push it shortly. It's probably fine to merge this and then still go ahead with the above separately.

Sarah-E-Greene commented 9 years ago

That'd be cool. Feel free to push up what you have, and we can refactor this.