search

flaport / fdtd

A 3D electromagnetic FDTD simulator written in Python with optional GPU support
https://fdtd.readthedocs.io
MIT License
455 stars 116 forks source link

Test workflows PoC #20

Closed iakovts closed 3 years ago

iakovts commented 3 years ago

(#19) With these changes, a github Action will run on any push to the repo, triggering unit tests. This can be modified to run only on selected branches, PRs etc. I 've also split the dev dependencies into: dev, docs and test to avoid the added overhead of packages not needed for testing (now that i think about it, pip install . && pip install pytest would be good at this stage too).

flaport commented 3 years ago

That's awesome!

I'd like to merge as is, but now that you're working on this (and only if it's not too difficult/time consuming).... would it be possible to add an action to release a wheel when I push a tagged commit (and when all test succeed)?

that's something I wanted for a while already, so now that there is someone with github actions knowledge I grab my chance 😅

flaport commented 3 years ago

merging this already as discussed in #19 , we can create new PRs for further additions to gitlab-ci.