search

flaport / inverse_design

https://flaport.github.io/inverse_design
Apache License 2.0
16 stars 5 forks source link

Migrate to nbdev v2? #3

Closed jan-david-fischbach closed 1 year ago

jan-david-fischbach commented 1 year ago

Is there a particular reason not to migrate? It seems like the github actions are currently failing because the nbdev command is not found.

flaport commented 1 year ago

The only reason I haven't done so, so far is because i know nbdev1 better. But converting a small repository like this would be the perfect opportunity to learn nbdev2. So yeah... Let's do it :)

jan-david-fischbach commented 1 year ago

I am currently preparing a pull request in my fork. I have migrated to nbdev version 2 according to the documentation. However, many things are still different to a project setup with nbdev_new (e.g. javiche) I have my first "successful" optimization. I'll do some cleanup and provide additional documentation.

generated opt result

Somehow nbdev_prepare doesn't seem to cleanout the notebooks as expected. I'll do some more digging

jan-david-fischbach commented 1 year ago

To avoid problems with the pending PRs #5 and #6 I suggest that we run nbdev_migrate after they have been closed.

flaport commented 1 year ago

Hi Jan-David, I merged #4 in one go. I had to do it manually because the PR was coming from your master branch and I could not push to it. But you should be able to cleanly merge my master branch into yours now.