flaport / inverse_design

https://flaport.github.io/inverse_design
Apache License 2.0
16 stars 5 forks source link

PATH modifications #8

Closed jan-david-fischbach closed 1 year ago

jan-david-fischbach commented 1 year ago

We still have quite a lot of

import sys; sys.path.insert(0, '..')

in the notebooks. With maturin in place now these should not be required anymore, as it installs the pyo3 bindings directly into the environment.

Suggestion: get rid of the PATH manipulations :)

flaport commented 1 year ago

The path modifications were removed during the merge. Did you merge my master back into yours?

jan-david-fischbach commented 1 year ago

Jep I did. I was however still sitting on old files locally. Resolved