031 - Githubissues

flaport / sax

S + Autograd + XLA :: S-parameter based frequency domain circuit simulations and optimizations using JAX.

https://flaport.github.io/sax

Apache License 2.0

70 stars 17 forks source link

031 #3

Closed joamatab closed 2 years ago

joamatab commented 2 years ago

Hi Floris,

Adding Some patches for bringing package back in shape

fix imports in init
update gdsfactory interface
add pre-commit for code quality
flake8 passing

Still needs some work

tests still not passing
03_circuit_yaml notebook not working

ValueError: partial object functools.partial(<function bend_euler at 0x7f8000092040>, cross_section={'function': 'cross_section'}) has incorrect arguments

flaport commented 2 years ago

Hey @joamatab ,

Thanks for your PR! I've merged the new master back into your branch. But... all the actions you've added seem to fail -- probably my fault, but since I'm not very acquinted with the actions you've added, can you make them work again? And maybe remove the ones that aren't relevant any longer?

Thanks :)

flaport commented 2 years ago

Closing - stale PR