Pull Requests run `publish.yml` action

flaport / sax

S + Autograd + XLA :: S-parameter based frequency domain circuit simulations and optimizations using JAX.

https://flaport.github.io/sax

Apache License 2.0

70 stars 17 forks source link

Pull Requests run `publish.yml` action #41

Closed jan-david-fischbach closed 1 month ago

jan-david-fischbach commented 1 month ago

Hey @flaport, I think we should avoid running the publish action on PRs (as it will inevitably fail). Or was there some reason behind setting it up this way?

To change this behavior we would only have to change this line: https://github.com/flaport/sax/blob/aabd9f9c9d8bf97c65f30cba5fe87cfac466fd84/.github/workflows/publish.yml#L4

Should I open a PR?

Regards JD

flaport commented 1 month ago

Thanks for noticing @jan-david-fischbach . I fixed it :)