flare-foundation / go-songbird

BSD 3-Clause "New" or "Revised" License
66 stars 32 forks source link

Review changes related to validator set #1

Closed awfm9 closed 2 years ago

awfm9 commented 2 years ago

At the moment, we are hijacking the validator manager's update function to return a static validator set. We should update the code so that we bootstrap using a static validator set from the genesis information instead, and then simply disable the updating of the set subsequently.

This would allow us to re-enable the genesis bootstrapping testing of validators, and would integrate the Flare logic more cleanly into Avalanche.

awfm9 commented 2 years ago

The latest version already improves on this, by instead hijacking the validator manager at the level of getting the validators. It bypasses the call to the chain state to get the list of validators, and instead returns a static set initialized on start-up. We can probably improve on this further, though.