search

flare-foundation / go-songbird

BSD 3-Clause "New" or "Revised" License
66 stars 32 forks source link

Test VMClient GetValidators & VMServer FetchValidators #26

Closed Ullaakut closed 2 years ago

Ullaakut commented 2 years ago

Goal of this PR

This PR adds two sets of tests for the methods we have added onto the VM Server and VM Client implementations.

In order to make this logic testable, it also adds two mocks. One mocks the GRPC Client internal to the VM Client, and the other mocks the ChainVM that the VM Server uses.

These test sets run tests in parallel and have no waiting time so their cost in terms of CI time is negligible.

Ullaakut commented 2 years ago

@awfm9 PR was rebased against master.