search

flareact / flareact-template

Template for Flareact projects
22 stars 252 forks source link

Add public folder with Flareact favicon inside. #2

Closed izznatsir closed 3 years ago

izznatsir commented 3 years ago

When I run a dev server in Edge Chromium, the console printed an error that said failed to get ./favicon.ico. This kind of error is a sign that the template is incomplete. So I add public folder along with the favicon.

It also showcase where the public folder should be located in Flareact project.

calendee commented 3 years ago

Literally came here just to do this. Thanks for being proactive @izznatsir!

samuelcolvin commented 3 years ago

This is currently breaking, wrangler generate ... completely, see #5.

I guess it either needs to get reverted or some fix needs to be added to allow favicon.ico to be included.