search

flaree / flare-cogs

Various cogs written for Red-DiscordBot
MIT License
76 stars 69 forks source link

[Giveaways] Fix when giveaway message is deleted (Sourcery refactored) #145

Closed sourcery-ai[bot] closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Pull Request #144 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to the original Pull Request

    Incorporate changes via command line 
    git fetch https://github.com/flaree/flare-cogs pull/144/head
git merge --ff-only FETCH_HEAD
git push

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.41%.

Quality metrics Before After Change
Complexity 12.45 🙂 12.14 🙂 -0.31 👍
Method Length 108.12 🙂 107.59 🙂 -0.53 👍
Working memory 14.63 😞 15.09 😞 0.46 👎
Quality 48.73% 😞 48.32% 😞 -0.41% 👎
Other metrics Before After Change
Lines 418 425 7
Changed files Quality Before Quality After Quality Change
giveaways/giveaways.py 48.73% 😞 48.32% 😞 -0.41% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
giveaways/giveaways.py Giveaways.draw_winner 33 ⛔ 362 ⛔ 28 ⛔ 11.20% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
giveaways/giveaways.py Giveaways.advanced 10 🙂 226 ⛔ 17 ⛔ 36.93% 😞 Try splitting into smaller methods. Extract out complex expressions
giveaways/giveaways.py Giveaways.on_raw_reaction_add 14 🙂 160 😞 17 ⛔ 38.68% 😞 Try splitting into smaller methods. Extract out complex expressions
giveaways/giveaways.py Giveaways.init 9 🙂 120 😞 16 ⛔ 48.60% 😞 Try splitting into smaller methods. Extract out complex expressions
giveaways/giveaways.py Giveaways.entrants 11 🙂 148 😞 10 😞 52.52% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!