flaree / lastfm-red

LastFM Ported to Red
MIT License
3 stars 3 forks source link

LastFm & Hybrid commands #18

Open flaree opened 1 year ago

flaree commented 1 year ago

Currently, we make use of *args and *, args in places as we have the parse func which deals with parsing the information to get the required arguments. Hybrid does not support these.

We also have multi nested commands which slash does not support in general. Ex fm tag track add, this would have to become fm track tagadd and so forth.

Creating this issue as a way to try and come up with a best approach.

Currently I see two solutions.

  1. We create separate slash commands and not hybrids, which would mean moving code out to its own functions and then having the prefix and slash command call them. This would allow us to keep prefix commands as is and just add slash command funcs.
  2. We reformat all commands to fix the structure to accommodate hybrids. Would need to figure out better way to handle both points listed above.

@Ryan5453

Ryan5453 commented 1 year ago

I'd honestly prefer the first solution because a lot of the code could use at least a refactor or an entire rewrite.