search

flaree / lastfm-red

LastFM Ported to Red
MIT License
3 stars 3 forks source link

feat/scrobbler #3

Closed Ryan5453 closed 2 years ago

Ryan5453 commented 2 years ago

This PR is currently set as a draft for two reasons:

1. It's a copy and paste from my other fork and I have not tested it yet

  1. Some feedback may be needed on the handling of the new API key and the DM it sends
Ryan5453 commented 2 years ago

I’ve now tested this and it appears to work although anyone’s feedback to the new API key and DM notification are welcome.

If the user has never loaded the cog before, they won’t receive the DM about setting the API secret, only people already running the cog will.

Upon updating the cog, the fm set command (which has been renamed to fm login with fm set as an alias since you no longer set your username) command will be disabled until the bot owner sets the API secret as the command needs it. Everything else will continue working perfectly without it set.

Ryan5453 commented 2 years ago

I believe it won’t be possible to fix the passing checks as last.fm requires a MD5 hashing function which CodeFactor dislikes.

flaree commented 2 years ago

I believe it won’t be possible to fix the passing checks as last.fm requires a MD5 hashing function which CodeFactor dislikes.

I'm not sure why that check even exists 😅