search

flarelabs-net / vite-environment-providers

1 stars 0 forks source link

Add module resolution tests for `cloudflare:` and `workerd:` imports #15

Closed dario-piotrowicz closed 1 month ago

dario-piotrowicz commented 1 month ago

As part of #14 I've removed the getApproximateSpecifier logic: https://github.com/flarelabs-net/vite-environment-providers/blob/89165dec4a879909a9299990c76f5cbb85a52955/packages/vite-environment-provider-cloudflare/src/moduleFallback.ts#L26-L32

https://github.com/flarelabs-net/vite-environment-providers/blob/89165dec4a879909a9299990c76f5cbb85a52955/packages/vite-environment-provider-cloudflare/src/moduleFallback.ts#L164-L169

I don't remember when/why I've introduced this function to be honest, I think I must have copy-pasted it from our vitest-pool-workers code

This function's removal does not cause any module resolution tests to fail so I think that it should be removed until it is proven to actually be necessary.

To ascertain if it is we should explore cloudflare: and workerd: imports as those seem related to the function's purpose.

dario-piotrowicz commented 1 month ago

[!NOTE] we should not concern ourselves with node: imports here but in #16 instead