search

flarelabs-net / vite-environment-providers

1 stars 0 forks source link

Add module resolution testing fixture with initial tests #6

Closed dario-piotrowicz closed 1 month ago

dario-piotrowicz commented 1 month ago

I've left some feedback (mainly minor points). Really good to start getting test coverage for these things! When I run the tests they run but then hang before the following is reported:

close timed out after 10000ms Tests closed successfully but something prevents Vite server from exiting You can try to identify the cause by enabling "hanging-process" reporter. See https://vitest.dev/config/#reporters

I haven't dug further.

Yeah, I do get that too 😓

I did want to investigate it but there's a good amount of other stuff to figure out that I didn't want to get bugged down on fixing that and that we could live with it 😅 (for now at least)

I'm happy to reconsider and spending time trying to see if I can remove it if you think this can be problematic 🙂

jamesopstad commented 1 month ago

Yeah, I do get that too 😓

I did want to investigate it but there's a good amount of other stuff to figure out that I didn't want to get bugged down on fixing that and that we could live with it 😅 (for now at least)

I'm happy to reconsider and spending time trying to see if I can remove it if you think this can be problematic 🙂

No, I think it's fine to leave that for now.