Fixing Q name change. - Githubissues

flaresimulations / synthesizer-grids

Scripts for generating synthesizer grids

https://flaresimulations.github.io/synthesizer/grids/grids.html

1 stars 1 forks source link

Fixing Q name change. #35

Closed WillJRoper closed 8 months ago

WillJRoper commented 8 months ago

Introduces log10 into specific ionising luminosity naming and fixes HDF5 key.

Issue Type

Checklist

[x] I have read the [CONTRIBUTING.md]()
[x] I have added docstrings to all methods
[x] I have added sufficient comments to all lines
[x] I have made corresponding changes to the documentation
[x] My changes generate no pep8 errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

WillJRoper commented 8 months ago

I'm afraid the GridHelper still needs implementing everywhere beyond the initial 2 places it was implemented. It's on my to-do list 😬 as a quick fix you could write a quick script to perform the renaming on the files you have but note that this PR changes it to log10_specific_ionising_lum as per @stephenmwilkins's request.

Anywhere the GridHelper is implemented will now work on this branch (or after merging it).

sophie-newman commented 8 months ago

conflicts need to be sorted and io changed to grid_io