flaresimulations / synthesizer-grids

Scripts for generating synthesizer grids
https://flaresimulations.github.io/synthesizer/grids/grids.html
1 stars 1 forks source link

Fixing naming of IO module #38

Closed WillJRoper closed 10 months ago

WillJRoper commented 10 months ago

The IO module name clashed with the python io module. This is now grid_io to differentiate it.

I have also introduced sys.path amending to make it importable in the scripts it was demoed in but these scripts are not updated with errors looking for a tag that does not exist in utils. However, they at least serve as a demonstration.

This needs to be fixed with an installation to make the reusable chunks importable anywhere in the package.

I also fixed an issue where the GridFile looked for a function which has since been attached to a Sed in Synthesizer.

In general, we can probably gain a lot by packaging up internal parts of synthesizer-grids in synthesizer objects.

Issue Type

Checklist

sophie-newman commented 10 months ago

you need to import sys in the files you've updated the path in