Closed WillJRoper closed 6 months ago
Hoki issue raised here: https://github.com/HeloiseS/hoki/issues/99
Hoki fix raised in this PR: https://github.com/HeloiseS/hoki/pull/100
found issues in some edits that were made to maraston13 - trying to fix these now
This PR is a monolithic fix of the incident spectra side of the repo. It is currently in draft as things progress but will track changes and list outstanding problems.
Changelog:
Parser
has been introduced which overloadsargparse.ArgumentParser
to implement some standard command line arguments for use across all scripts. This has been implemented in all scripts.GridFile
now writes version and time metadata automatically and has been implemented in all scripts.utilities
module has been introduced to house the tools for use across the scripts.Current status:
hoki
hasn't fixed theupdate_default_config
astropy
issue. This could be fixed by pinning the version but we should probably raise an issue on their end to have it fixed.TODO list:
requests
unyt
conversions instead of magic numbers.Issue Type
Checklist