Change arguments in the big fix

[stephenmwilkins]

A few changes rolled into one since they emerged while I was working on the main one:

• Replaced synthesizer_data_dir argument with grid_dir and input_dir to avoid use of implicit subdirectories.
• bc03-2016 now completely works. To work the this needs to convert the binary files into ascii. This currently works by downloading some fortran code, compiling it, and running it. Running all the bc03-2016 grids is slow, due to the photon luminosity step.
• bpass scripts now work except for the download functionality.
• Made some further modifications to maraston scripts to harmonise with synthesizer (e.g. consistent file names).
• Docs modified to reflect this.

Issue Type

• [x] Bug
• [x] Document
• [x] Enhancement

Checklist

• [x] I have read the [CONTRIBUTING.md]()
• [x] I have added docstrings to all methods
• [x] I have added sufficient comments to all lines
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no pep8 errors
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes

[stephenmwilkins]

Implemented in install_bc03.py and install_bc03-2016.py but due to download issues not tested yet. Let me know if you want me to propagate these changes to the other installs or have suggestions.

[WillJRoper]

Of course for now the BPASS scripts won't run regardless.

[stephenmwilkins]

Could you double check that these files have been run through black? I can see a couple instances where there are non compliant formatting issues. We will be moving to this soon so best to do now

I believe this is now fixed (swapped to using black instead of autopep8 in VSCode). I have not completely fixed the install_bpass since they still don't work.

[christopherlovell]

Could you double check that these files have been run through black? I can see a couple instances where there are non compliant formatting issues. We will be moving to this soon so best to do now

I believe this is now fixed (swapped to using black instead of autopep8 in VSCode). I have not completely fixed the install_bpass since they still don't work.

Is this still a Hoki issue? I believe @WillJRoper fixed this, unless it hasn't been merged yet

[stephenmwilkins]

@christopherlovell @WillJRoper has a PR that hasn't been accepted yet with no response from the authors. We might have to re-write our own parser.

[stephenmwilkins]

@WillJRoper noted that we could force the version of astropy while hoping Hoki update.

[stephenmwilkins]

bpass now works (without using hoki) but downloads do not.