search

flaresimulations / synthesizer-grids

Scripts for generating synthesizer grids
https://flaresimulations.github.io/synthesizer/grids/grids.html
1 stars 1 forks source link

Spectra units are wrong #50

Open stephenmwilkins opened 9 months ago

stephenmwilkins commented 9 months ago

Technically, the units of spectra in most grids are erg / s / Hz / Msun not erg / s / Hz. Changing this may have unintended consequences though.

WillJRoper commented 9 months ago

Yea, this is an issue but unyt isn't fully used everywhere (it should be and is one of the checkpoints on #42). We should adjust this when we do that.

christopherlovell commented 9 months ago

What do you mean by 'most'? shouldn't that be the case for all grids?

I agree it's technically incorrect, but the assumption is carried through to all later operations on grid objects, so shouldn't affect anything. If we want to include this I would rather do this after merging with the main repo so it can be thoroughly tested

stephenmwilkins commented 9 months ago

@christopherlovell not for non-SPS grids where "erg / s / Hz" is still appropriate. This is because for (some of) these grids Mbh is a parameter which doesn't just scale the luminosity.

christopherlovell commented 9 months ago

That's fair. Feel free to raise a PR addressing this. I believe it will require quite extensive changes to ensure the mass dependence is cancelled out when e.g. integrating spectra