flaresimulations / synthesizer-grids

Scripts for generating synthesizer grids
https://flaresimulations.github.io/synthesizer/grids/grids.html
1 stars 1 forks source link

Cloudy big fix #55

Closed stephenmwilkins closed 8 months ago

stephenmwilkins commented 8 months ago

This is mostly concerned with updating the cloudy grid generation functionality.

I have not:

Issue Type

Checklist

sophie-newman commented 8 months ago

What is c23.01-sps-c17.03.yaml ? Confused about it being both c23.01 and c17.03

stephenmwilkins commented 8 months ago

What is c23.01-sps-c17.03.yaml ? Confused about it being both c23.01 and c17.03

Understandable confusion, this is going to be for testing. When we implement c23.01 there are going to be different default choices from c17.03. This parameter file is meant for running c23.01 but using the default choices in c17.03. I couldn't think of a better name!

sophie-newman commented 8 months ago

What is c23.01-sps-c17.03.yaml ? Confused about it being both c23.01 and c17.03

Understandable confusion, this is going to be for testing. When we implement c23.01 there are going to be different default choices from c17.03. This parameter file is meant for running c23.01 but using the default choices in c17.03. I couldn't think of a better name!

Ah I see. I did create a c23.01 param file though using the c17.03 params assuming they would be updated in time

stephenmwilkins commented 8 months ago

FYI this now works correctly insofar as it can be used to generate cloudy input grid and then a synthesizer reprocessed grid.

sophie-newman commented 8 months ago

I will run these changes through my codes tomorrow when I have more time to check them before merging anything