Closed sophie-newman closed 1 week ago
Looking good so far! I'm going to make some more specific comments on the changes but one big thing: the dataset names must be plural (i.e. age -> ages, metallicity -> metallicities). This is so we can automate reading axes on the Synthesizer side.
I want also to be able to change the axis name when log_on_read is True, e.g. age -> log10age. I'm struggling to find a nice way to incorporate this into grid_io however so any help is appreciated.
I'm not 100% sure I know what you mean here. Do you mean in the grid_axes? If so just leave that as the linear versions. We'll handle the necessary prefixes when read on the Synthesizer side.
Here the following changes have been made to grid_io and in the grid creation scripts:
Currently, changing log10ages to age will cause some issues:
fig, ax = grid.plot_specific_ionising_lum(ion='HI')
with this new grid then you will get the errorAttributeError: 'Grid' object has no attribute 'log10age'
since this assumes log10ageAfter this PR, the following PRs then need to be done:
Issue Type
Checklist