flaresimulations / synthesizer-grids

Scripts for generating synthesizer grids
https://flaresimulations.github.io/synthesizer/grids/grids.html
1 stars 1 forks source link

grid_io changes #74

Closed sophie-newman closed 1 week ago

sophie-newman commented 3 weeks ago

Here the following changes have been made to grid_io and in the grid creation scripts:

After this PR, the following PRs then need to be done:

Issue Type

Checklist

WillJRoper commented 3 weeks ago

Looking good so far! I'm going to make some more specific comments on the changes but one big thing: the dataset names must be plural (i.e. age -> ages, metallicity -> metallicities). This is so we can automate reading axes on the Synthesizer side.

WillJRoper commented 3 weeks ago

I want also to be able to change the axis name when log_on_read is True, e.g. age -> log10age. I'm struggling to find a nice way to incorporate this into grid_io however so any help is appreciated.

I'm not 100% sure I know what you mean here. Do you mean in the grid_axes? If so just leave that as the linear versions. We'll handle the necessary prefixes when read on the Synthesizer side.