flaresimulations / synthesizer-grids

Scripts for generating synthesizer grids
https://flaresimulations.github.io/synthesizer/grids/grids.html
1 stars 1 forks source link

Unifying Cloudy scripts with sps incident scripts #76

Closed WillJRoper closed 1 week ago

WillJRoper commented 2 months ago

To ensure consistency, and importantly consistent naming and units, this PR introduces the Parser and GridFile to the cloudy scripts.

Currently an open draft to enable collaboration.

Issue Type

Checklist

sophie-newman commented 2 months ago

why the hf=None? is that just for testing?

WillJRoper commented 2 months ago

why the hf=None? is that just for testing?

That's literally just so the script with the few changes I had made would make it past the commit checks. I've done very little so far here but opened it in draft so we can work together on it.

sophie-newman commented 1 week ago

I have tested this and everything is looking as expected!

Main changes in this PR:

WillJRoper commented 1 week ago

This looks fine to me. There could be some hidden gremlins but I don't see them. The proof will be in the pudding.

@christopherlovell I can't approve this since I made the original PR.