Closed WillJRoper closed 1 week ago
why the hf=None
? is that just for testing?
why the
hf=None
? is that just for testing?
That's literally just so the script with the few changes I had made would make it past the commit checks. I've done very little so far here but opened it in draft so we can work together on it.
I have tested this and everything is looking as expected!
Main changes in this PR:
create_synthesizer_grid
for a few example axes (reference_ionisation_parameter
, ionisation_parameter
, metallicities
, ages
). If an automatic way could be found, this would be preferred but it is hard to do this from the .yaml file.create_synthesizer_grid
rather than create_cloudy_input_grid
--
rather than -
This looks fine to me. There could be some hidden gremlins but I don't see them. The proof will be in the pudding.
@christopherlovell I can't approve this since I made the original PR.
To ensure consistency, and importantly consistent naming and units, this PR introduces the
Parser
andGridFile
to the cloudy scripts.Currently an open draft to enable collaboration.
Issue Type
Checklist