search

flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables
https://flaresimulations.github.io/synthesizer/
GNU General Public License v3.0
17 stars 9 forks source link

Use a single argument on parametric `Stars` to accept sfh/Z function or array #420

Closed christopherlovell closed 11 months ago

christopherlovell commented 12 months ago

There are currently two separate arguments on Stars to accept either functional forms of the SFH/Z distribution (sf_hist_func / metal_dist_func) and two arguments for arrays (sf_hist / metal_dist). Can we combine these, and have some logic in the background to interpret what the user provides?

The number of arguments could also be reduced / simplified by removing the instant_sf and instant_metallicity options, as these arguably can be accomodated within distributions, but no strong feelings on this point.

WillJRoper commented 12 months ago

Agreed! That would streamline things hugely. Just sf_hist and metal_dist? I don't see why we don't just fold the instantaneous ones in to. In hindsight, it is a bit cumbersome with individual arguments for both.