flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables
https://flaresimulations.github.io/synthesizer/
GNU General Public License v3.0
17 stars 8 forks source link

Masking issue in blackhole modelling #567

Closed stephenmwilkins closed 4 months ago

stephenmwilkins commented 5 months ago

The current use of masks means that if the disc is behind the torus the disc_incident emission is set to zero. This problematic since then the torus emission is zero. This can be fixed by setting the mask for the disc_incident creation to None and multiplying self.spectra["disc_incident"] by mask when calculating the total transmitted spectra.

There was also a bug where a zero spectra was set as np.zeros(grid.lam) instead of np.zeros(len(grid.lam))

Fix incoming.

WillJRoper commented 4 months ago

Fixed in #570