flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables
https://flaresimulations.github.io/synthesizer/
GNU General Public License v3.0
17 stars 7 forks source link

Allow arbitrary masks #616

Closed stephenmwilkins closed 5 days ago

stephenmwilkins commented 2 months ago

For particle based methods at the moment we can only mask with the young and old arguments. We should add an option mask argument that allows the use of a generic mask. I believe this simply means adding mask to list of arguments and then modifying _get_mask.

WillJRoper commented 2 months ago

This issue has grown to highlight a more general issue. The following is taken from slack detailing the proposed solution to clean all of this up:

WillJRoper commented 2 months ago

Possibly a redundant point now but there's no need for get_transmission to take a mask. Sed.apply_attenuation takes a mask and is the intended way to attenuate a spectra. Calculating a transmission should transparently adopt the shape of the input tau_v array.

Of course this may be superseded by the EmissionModel approach soon to be raised.