Small fixes - Githubissues

flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables

https://flaresimulations.github.io/synthesizer/

GNU General Public License v3.0

17 stars 9 forks source link

Small fixes #692

Closed christopherlovell closed 3 months ago

christopherlovell commented 3 months ago

Small fixes to Swift-EAGLE CAMELS load method.
Creates a log10metallicities property on gas components.
Fixes masking errors when using apertures, parametric_young_stars and other masks simultaneously

Issue Type

Bug

Checklist

[x] I have read the [CONTRIBUTING.md]() -->
[x] I have added docstrings to all methods
[x] I have added sufficient comments to all lines
[x] I have made corresponding changes to the documentation
[x] My changes generate no pep8 errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

WillJRoper commented 3 months ago

Should we just move the log10 properties to the Particles base class?