Fixing some Unified AGN bugs - Githubissues

flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables

https://flaresimulations.github.io/synthesizer/

GNU General Public License v3.0

17 stars 9 forks source link

Fixing some Unified AGN bugs #731

Closed stephenmwilkins closed 2 months ago

stephenmwilkins commented 2 months ago

Fixes a couple of bugs:

When a parameter is fixed in an extraction it wasn't reset the parameter on the component. Since cosine_inclination is fixed as part of UnifiedAGN this led to this parameter being permanently changed.
Some of the masking choices on UnifiedAGN was incorrect. The NLR should always be visible, and thus never masked.

Issue Type

Bug

Checklist

[x] I have read the [CONTRIBUTING.md]() -->
[x] I have added docstrings to all methods
[x] I have added sufficient comments to all lines
[x] I have made corresponding changes to the documentation
[x] My changes generate no pep8 errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

stephenmwilkins commented 2 months ago

Sorry... I foolishly merged the dust_emission_clean_up branch.