This PR fixes an issue that only became apparent when testing the line emission functionality of the Unified AGN. This emerged because the scaling applied in the emission model was wrong.
The best way of fixing this was deemed to be normalising the spectra, and line emission quantities, in the grid file by the isotropic bolometric luminosity. With this in place the scaling to be applied to the spectra is simply the bolometric luminosity of each BH.
This testing also suggests an independent bug (or physics) in the BLR modelling, likely at the cloudy modelling stage. I'm working to identify this but it is independent of this PR.
This will require an update of the AGN test grid. However, that can probably wait until the BLR bug is caught since no one should be using the AGN modelling yet and any other PRs using the AGN modelling should still pass (though be very wrong).
Issue Type
[x] Bug
Checklist
[x] I have read the [CONTRIBUTING.md]() -->
[x] I have added docstrings to all methods
[x] I have added sufficient comments to all lines
[x] I have made corresponding changes to the documentation
[x] My changes generate no pep8 errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
This PR fixes an issue that only became apparent when testing the line emission functionality of the Unified AGN. This emerged because the scaling applied in the emission model was wrong.
The best way of fixing this was deemed to be normalising the spectra, and line emission quantities, in the grid file by the isotropic bolometric luminosity. With this in place the scaling to be applied to the spectra is simply the bolometric luminosity of each BH.
Issue Type
Checklist