Generalise ionising photon calculation to arrays - Githubissues

flaresimulations / synthesizer

Synthesizer - a code for creating synthetic astrophysical observables

https://flaresimulations.github.io/synthesizer/

GNU General Public License v3.0

17 stars 9 forks source link

Generalise ionising photon calculation to arrays #761

Closed stephenmwilkins closed 1 month ago

stephenmwilkins commented 1 month ago

At the moment Sed.calculate_ionising_photon_luminosity() doesn't work for arrays of spectra. This fixes this.

Issue Type

[x] Bug

Checklist

[x] I have read the [CONTRIBUTING.md]() -->
[x] I have added docstrings to all methods
[x] I have added sufficient comments to all lines
[x] I have made corresponding changes to the documentation
[x] My changes generate no pep8 errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

stephenmwilkins commented 1 month ago

I've generalised it nD and added some examples to the docs demonstrating this. However, this revealed that several other methods on Sed don't work in 3D. I'll raise an issue for these.