Vel shift spectra marco

[marcoleonardi97]

Issue Type

• Bug
• Document
• Enhancement

Checklist

• [x] I have read the [CONTRIBUTING.md]() -->
• [x] I have added docstrings to all methods
• [x] I have added sufficient comments to all lines
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no pep8 errors
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes

[marcoleonardi97]

Added flags from the front-end (component.get_spectra) to the stars generate_lnu and generate_particle_lnu. Won't work yet because we need to parse velocities as an argument in prepare_sed_args. Generate_lnu also uses compute_integrated_sed instead of compute_particle_sed, need to modify that too?

[WillJRoper]

Generate_lnu also uses compute_integrated_sed instead of compute_particle_sed, need to modify that too?

I was thinking about this on my drive this morning. The easiest way to handle this would actually be to call your spectra generation function from within either compute_integrated_sed or compute_particle_sed if the velocity flag is true. (rather than have the whole separate script). That way we don't need such extensive edits and you don't need to worry so much about the front end (only what you've already done).

To be clear I mean having something like this in the compute_integrated_sed and compute_particle_sed functions:

if (with_vel_shift) {
   <call your function>
 } else {
   <call_the_old_function>
}

[marcoleonardi97]

added double const c and check for ilam < 0

[marcoleonardi97]

modified the particle_spectra.c directly so we can choose which functions to call when, i just duplicated the ngp and cic wrappers and made the respective shifted versions. (Not sure if having 2 functions for task is more of less efficient than having 1 with a flag, but should work anyways).

added flag to generate_particle_lnu for black holes,

only thing left to do (i think) should be reworking compute_integrated_sed in the same way of compute_particle_sed, then see how these all work when they are called in a galaxy object