search

flareteam / flare-engine

Free/Libre Action Roleplaying Engine (engine only)
http://flarerpg.org/
GNU General Public License v3.0
1.1k stars 186 forks source link

Android Flare Engine v1.14 APK showing as version 1.12 #1874

Closed BRBsoup closed 10 months ago

BRBsoup commented 11 months ago

In-game is shown properly, but the APK install package/android manifest info shows as "1.12"/"112"

BRBsoup commented 11 months ago

I think the APK being distributed was just built with the old manifest, or something like that, as in the source code on github the manifest correctly shows 1.14/114, yet the APK distributed still shows 1.12/112, I haven't tried compiling from source

dorkster commented 11 months ago

I believe this is just the F-Droid manifest containing the wrong version number. I'll look into getting this fixed.

Also, no need to double-post on both flare-engine and flare-game.

BRBsoup commented 11 months ago

Screenshot_20231105_022833_My Files Screenshot_20231105_022844_Package Manager Screenshot_20231105_022851_Package Manager Screenshot_20231105_022910_Droid-ify

I believe this is just the F-Droid manifest containing the wrong version number. I'll look into getting this fixed.

Also, no need to double-post on both flare-engine and flare-game.

Sorry for double post, I wasn't sure because the APK is distributed under flare-game. It's happening on the APK distributed here, so not sure about F-Droid. In fact, I saw that F-Droid version was 1.12 and older. So I went directly to the website. Not sure if its relevant, but when installed not through F-Droid, F-Droid thinks I have 1.12 installed yet it doesn't recognize it as the 1.12 version in the F-Droid repo (which still shows up as "Suggested" rather than "Installed"). Everything I can see about it, I've shown in the screenshots here. Hope it helps.

dorkster commented 11 months ago

Wait, I think you're right. I just built it and the APK version still says 1.12. Not sure where it's getting that number from, since AndroidManifest.xml has 1.14. The F-Droid manifest still needs to be corrected, but it needs to be fixed on our end first.

BRBsoup commented 11 months ago

Wait, I think you're right. I just built it and the APK version still says 1.12. Not sure where it's getting that number from, since AndroidManifest.xml has 1.14. The F-Droid manifest still needs to be corrected, but it needs to be fixed on our end first.

I attached a few screenshots which shows my APK installer showing the manifest as 112 yet on github manifest source code its 114. Yeah, it's odd. Good luck figuring it out, versioning is pretty important for Android apps, though at least it doesn't seem to affect any of the actual engine/game. Also, thank you!

dorkster commented 11 months ago

I completely forgot that I fixed this, but it was after the v1.14 tag. So my v1.14 builds didn't have it.

I made the v1.14-android tag with the fix cherry-picked. I'll rebuild our APKs with it, as well as submit a fixed manifest to F-Droid (once CI finishes).

Update: APKs updated on Github/SourceForge. F-Droid fix merged: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13989