third party extension support

flarum-lang / german

:de: German language pack for Flarum.

https://discuss.flarum.org/d/2648

MIT License

21 stars 12 forks source link

third party extension support #14

Closed StoneSoldier closed 3 years ago

StoneSoldier commented 7 years ago

Sollen wir die Übersetzungen von third Party Extensions ins Language pack oder in die einzelnen Extensions tun?

Kakifrucht commented 7 years ago

Gute Frage, wenn ich mir andere Projekte anschaue, dann scheinen diese durchaus zT auch nicht gebundlete extensions mit einzubegreifen. Das bedeutet dann aber natürlich auch, dass diese unterhalten werden müssten.

Mein Votum: Es bei den zentralen zu belassen. Ich denke schon, dass sich die Entwickler darüber freuen würden die Übersetzungen direkt bei sich mitliefern zu können.

StoneSoldier commented 7 years ago

Kakifrucht commented 5 years ago

Closing this for now, feel free reply if you still want to discuss this!

OddDev commented 5 years ago

I think that paradigm will not work on the long-run since Friends of Flarum decided to put the language packs responsible to translate stuff. https://github.com/FriendsOfFlarum/links/pull/13#issuecomment-532831880 https://discuss.flarum.org/d/19971-extensions-translation-in-their-own-repository-or-in-language-pack

Currently, I'm not able to commit to the third-party extension nor to the language pack. My only option is to install FoF/linguist and translate everything manually decentralised.

luceos commented 5 years ago

There are a few options:

fork this language pack into one that supports more extensions, fragmenting translation efforts for the German language
stick to (what I think is a great option) core extensions for one language pack and create another one for third party extensions
create a local extender to load your custom translation files for your specific installation (better than using linguist)
join this initiative https://discuss.flarum.org/d/20807

Kakifrucht commented 5 years ago

I just went through the given options and my preference is probably to add another extension/repository just for third party plugins. It seems like the cleanest approach and adds a nice centralized repository to collect all translations to. But I'm not sure if one language can trivially fetch translations from two extensions, or does this work out of the box when simply enabling the 'flarum-de-extended' (or similiar) extension, without having it register as an additional language?

rob006's approach looks interesting, but given that my workflow to update flarum-de for the core extensions is already very simple, I would rather not add additional complexity/dependency on top of it. It definitely might make sense for a potential flarum-de-extended extension!

luceos commented 5 years ago

@Kakifrucht I gave a recent pilot another attempt since I posted my comment. It's quite similar to the one rob006 has, feel free to chat me up on discord. It's not yet part of the flarum organisation, but really well on its way to be and we could use a reliable translator for German.

It also splits core vs third party extensions and uses lokalise in the background:

Most of this should be automated pretty soon using GitHub actions and I might even be able to load in new, commonly used extension translation without human interaction as well.

See https://github.com/flarum-lang

Kakifrucht commented 5 years ago

Looks like a great idea to centralize it this way imo, certainly interested in helping out! I wasn't able to message you on Discord for some reason.

luceos commented 5 years ago

Add me as a friend first. I will accept asap.

OddDev commented 5 years ago

Also sent you one. Count me in :)

luceos commented 5 years ago

@OddDev didn't get one Kai..

Kakifrucht commented 3 years ago

I have setup a flarum-de-extended repository with support for a couple extensions that I use. Please PR whichever extensions you would like to have added!