search

flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.39k stars 835 forks source link

[Mobile] Sliding discussion item while dark mode is enabled causes b-color issue #1548

Closed ardacebi closed 4 years ago

ardacebi commented 6 years ago

Bug Report

Current Behavior Sliding a discussion item on the discussion list while dark mode is enabled causes the background color of the list to become white because of manual color setting (line 44):

https://github.com/flarum/core/blob/c16ddf24f2159c36e9026cb89457ec929a081fcc/less/forum/Slidable.less#L42-L48

Steps to Reproduce

  1. Enable Dark Mode
  2. Launch Flarum home screen on mobile
  3. Start sliding a discussion to reveal more button
  4. See error

Expected Behavior Background color should stay something dark to match up with dark mode.

Screenshots

Environment

matteocontrini commented 4 years ago

Hello, this is still an issue.

Would it be a solution to use the @control-bg variable instead of the hardcoded white, as the Night Mode extension was doing?

https://github.com/FriendsOfFlarum/nightmode/blob/b972c5ffcd6875be3d98fdbb87a1856dfcd36334/resources/less/forum/extension.less#L490-L500

askvortsov1 commented 4 years ago

That definitely seems like a sensible solution! A PR would be welcome