flarum / framework

Simple forum software for building great communities.
http://flarum.org/
6.27k stars 826 forks source link

Possibile issue with posts and profile (public / private ) #1746

Closed PeopleInside closed 5 years ago

PeopleInside commented 5 years ago

Bug Report

Current Behavior

User admin peopleinside is an administrator. It has public posts and private posts, private posts are associated to a tag restricted to only admin.

If you visit the peopleinside profile as visitor: https://community.peopleinside.it/u/peopleinside you can see Messaggi (Post): 139 but the list is empty to the visitor.

peopleinside profile should have public posts listed and the number 139 is not correct to the visitor side, should count only posts allowed (public) instead of show a empty list.

00

An example of public post made by peopleinside and visible to visitor is here: https://community.peopleinside.it/d/19-vulnerabilit-phishing-in-firefox-chrome-opera-unicode-domains-2017/2

If i am logged as admin i can see the 139 post listed also, all correct but not into the visitor side...

Steps to Reproduce

Create some private posts. How? Associate then to a private tag accessible only to admin. Make profile admin to be visible by everyone, visit it.

I don't know in a new install (not tested) but on my existent install public posts are not showed in my user profile, posts list.

Expected Behavior See listed public posts in the profile

Environment


Output of "php flarum info", run this in terminal in your Flarum directory.

`Loaded extensions: Core, date, libxml, pcre, dom, fileinfo, filter, hash, json, SPL, bz2, posix, Reflection, session, SimpleXML, standard, xml, xmlreader, xmlwriter, bcmath, openssl, calendar, ctype, curl, dba, mbstring, ftp, gd, gettext, gmp, iconv, imap, intl, ldap, exif, zlib, pcntl, PDO, pdo_sqlite, shmop, soap, sockets, sqlite3, sysvsem, sysvshm, tidy, tokenizer, wddx, xmlrpc, xsl, zip, Phar, mysqlnd, mysqli, pdo_mysql, ionCube Loader, Zend OPcache
+------------------------------+-----------------+--------+
| Flarum Extensions | | |
+------------------------------+-----------------+--------+
| ID | Version | Commit |
+------------------------------+-----------------+--------+
| flarum-approval | v0.1.0-beta.8 | |
| flarum-bbcode | v0.1.0-beta.8 | |
| flarum-emoji | v0.1.0-beta.8 | |
| flarum-flags | v0.1.0-beta.8.1 | |
| flarum-likes | v0.1.0-beta.8.1 | |
| flarum-lock | v0.1.0-beta.8 | |
| flarum-mentions | v0.1.0-beta.8.1 | |
| flarum-sticky | v0.1.0-beta.8 | |
| flarum-subscriptions | v0.1.0-beta.8 | |
| flarum-suspend | v0.1.0-beta.8 | |
| flarum-tags | v0.1.0-beta.8.2 | |
| flarum-lang-english | v0.1.0-beta.8 | |
| flarum-statistics | v0.1.0-beta.8 | |
| flarum-akismet | v0.1.0-beta.8 | |
| nearata-lang-italian | v0.1.0-beta.8.2 | |
| flarum-auth-facebook | v0.1.0-beta.8 | |
| flagrow-terms | 0.3.1 | |
| fof-links | 0.1.1 | |
| flarum-auth-github | v0.1.0-beta.8 | |
| fof-user-bio | 0.1.1 | |
| flarum-pusher | v0.1.0-beta.8.1 | |
| reflar-twofactor | 0.1.0-beta.4.2 | |
| flarum-auth-twitter | v0.1.0-beta.8 | |
| flagrow-upload | 0.7.0 | |
| flarum-markdown | v0.1.0-beta.8 | |
| fof-default-user-preferences | 0.1.0 | |
+------------------------------+-----------------+--------+
Base URL: https://community.peopleinside.it
Debug mode: off`

**Possible Solution**
<!--- Only if you have suggestions or a fix for the bug -->

**Additional Context**
Add any other context about the problem here.
PeopleInside commented 5 years ago

Discussion showed in my profile is 69 but for the user is not listed 69 topics. Is this number correct? Maybe so the post issue can be not the number 139 but the fact there are no public post listed ?!

Should post and discussion number be relative to what the visitor see or should include all posts also not visible posts for the user?

mmmmm... i cannot understand. Also logged as admin i cannot see listed 139 posts and 69 topics.

For example: https://discuss.flarum.org/u/jordanjay29 has 5776 post but you can see only a list of 10 post. Same for discussion. Is this really correct? It's working as indeed?

If yes seems you cannot have a real list of the user posts / topics if you need find something on the user profile.

franzliedke commented 5 years ago

Closing this as duplicate of flarum/issue-archive#321 and flarum/framework#1722.