Installing Flarum from /index.php causes wrong base url

clarkwinkelmann commented 5 years ago

Bug Report

Current Behavior Installing Flarum from /index.php works but causes an invalid url to be used in config.php, thus preventing access to the forum after install.

Steps to Reproduce

Install Flarum according to https://flarum.org/docs/install.html
At the step "navigate to your forum in a web browser", append /index.php at the end
Follow the web installation
When install is finished, you are redirected to /index.php which shows "Something went wrong while trying to load the full version of this site. Try hard-refreshing this page to fix the error" Accessing / shows the same error
Assets are loaded from /index.php/assets/forum-575aab17.css which causes 404 errors
You can observe /index.php being used in config.php

Expected Behavior The installation page should either not be available at /index.php, or remove index.php from the install url automatically.

Screenshots Probably not needed, let me know otherwise.

Environment

Flarum version: beta 9, and probably dev-master
Webserver: apache, but probably others
Hosting environment: tried locally

Output of "php flarum info", run this in terminal in your Flarum directory.

It's a blank install.

When enabling debug mode, the assets show the following 500 error:

Flarum\Http\Exception\RouteNotFoundException: /assets/forum-575aab17.css in file /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php on line 60
Stack trace:
  1. Flarum\Http\Exception\RouteNotFoundException-&gt;() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php:60
  2. Flarum\Http\Middleware\DispatchRoute-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
  3. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php:58
  4. Flarum\Http\Middleware\ShareErrorsFromSession-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
  5. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/SetLocale.php:51
  6. Flarum\Http\Middleware\SetLocale-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
  7. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php:25
  8. Flarum\Http\Middleware\CheckCsrfToken-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
  9. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php:34
 10. Flarum\Http\Middleware\AuthenticateWithSession-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 11. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php:52
 12. Flarum\Http\Middleware\RememberFromCookie-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 13. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/StartSession.php:62
 14. Flarum\Http\Middleware\StartSession-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 15. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/CollectGarbage.php:48
 16. Flarum\Http\Middleware\CollectGarbage-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 17. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php:29
 18. Flarum\Http\Middleware\ParseJsonBody-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 19. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Middleware/HandleErrorsWithWhoops.php:43
 20. Flarum\Http\Middleware\HandleErrorsWithWhoops-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 21. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php:83
 22. Zend\Stratigility\MiddlewarePipe-&gt;process() /home/clark/Projects/flarum-install/vendor/middlewares/request-handler/src/RequestHandler.php:84
 23. Middlewares\RequestHandler-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 24. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/middlewares/base-path-router/src/BasePathRouter.php:97
 25. Middlewares\BasePathRouter-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 26. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Middleware/OriginalMessages.php:41
 27. Zend\Stratigility\Middleware\OriginalMessages-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 28. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/middlewares/base-path/src/BasePath.php:53
 29. Middlewares\BasePath-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/Next.php:60
 30. Zend\Stratigility\Next-&gt;handle() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php:83
 31. Zend\Stratigility\MiddlewarePipe-&gt;process() /home/clark/Projects/flarum-install/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php:72
 32. Zend\Stratigility\MiddlewarePipe-&gt;handle() /home/clark/Projects/flarum-install/vendor/zendframework/zend-httphandlerrunner/src/RequestHandlerRunner.php:95
 33. Zend\HttpHandlerRunner\RequestHandlerRunner-&gt;run() /home/clark/Projects/flarum-install/vendor/flarum/core/src/Http/Server.php:46
 34. Flarum\Http\Server-&gt;listen() /home/clark/Projects/flarum-install/public/index.php:22

Possible Solution Same as expected behavior.

Additional Context Multiple people seem to have hit issues that could be related to this. Most recently https://discuss.flarum.org/d/21143-fatal-error-please-help but I'm not 100% sure this is the same issue. Other people had managed to get an index.php in their config.php and this is probably one way to inadvertently do it.

franzliedke commented 5 years ago

Nice catch. Yes, the script name (if present) should be removed from the base URL.

If anybody wants to send a PR, these are the relevant lines:

relax4o commented 5 years ago

The installation process where the base url is involved causes even more problems.

I've made some changes and when I test all cases properly, I can create a PR.

The issues I've found:

Using the console installer, if you omit the base url it'll add an incorrect setting mail_from => noreply@ which later if you don't fix this from the admin panel and you try to create (for example) a new account, the Mailer will throw an exception complaining about the email address format.
If you provide a base url but omit the protocol (http(s)) it'll break the website as it'll try to load assets from an incorrect url. Example: baseUrl = 'flarum.com' - Result: http://flarum.com/flarum.com/ANY-ASSETS

I can think of couple of solutions when the console installer is used:

Normalising the base url no matter what is provided (this works for console and web installers)
Requiring protocol
Making the base url mandatory + requiring protocol

Excuse me if the issues I've found sounds like they need to be in a different issue thread. I am kind of new to open source contribution.

flarum / framework

Installing Flarum from /index.php causes wrong base url #1861

Bug Report