Open orschiro opened 2 years ago
can reproduce
@orschiro can you still reproduce this in v1.5 ? I can't reproduce anymore.
@SychO9 yes, it's still happening for me on v1.5. See below example.
@SychO9 this relates to notifications generated via flarum/subscriptions
, rather than the regular flarum/mentions
notification.
I've just replicated with 1.6-dev
:
[2022-11-05 08:12:22] flarum.INFO: Message-ID: <3f1d50e6c6e44871582ec91edbb8852b@dev.morland.it>
Date: Sat, 05 Nov 2022 08:12:22 +0000
Subject: [New Post] test
From: Flarum Dev Docker <noreply@localhost>
To: admin <admin@example.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hey admin!
Lowerclass-Order made a post in a discussion you're following: test.
To view the new activity, check out the following link:
https://dev.morland.it/d/11/11
---
hey @"[deleted]"#1
---
You won't receive any more notifications about this discussion until you're up-to-date.
[2022-11-05 08:28:42] flarum.INFO: Message-ID: <10a6bd1d63958355a109056a90e3b199@dev.morland.it>
Date: Sat, 05 Nov 2022 08:28:42 +0000
Subject: [New Post] test
From: Flarum Dev Docker <noreply@localhost>
To: admin <admin@example.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Hey admin!
Lowerclass-Order made a post in a discussion you're following: test.
To view the new activity, check out the following link:
https://dev.morland.it/d/11/12
---
@"[unknown]"#p236 hi
---
You won't receive any more notifications about this discussion until you're up-to-date.
Extension load order also has an impact here.
mentions
before subscriptions
= no notificationsubscriptions
before mentions
= notification, but with deleted
/unknown
rendered for the user/post mention.I assume the upcoming GroupMention
and TagMention
would also be impacted by this too
It is reproducible on Flarum 1.8.5, too, using extension tpokorra-post-notification
0.4.8.
Example:
Related to: https://github.com/flarum/mentions/pull/71#issuecomment-1029804973
Happened to me on Flarum 1.2.0.