fix: unreadable badge icon on certain colors - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.36k stars 835 forks source link

fix: unreadable badge icon on certain colors #3810

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Fixes #3805

Changes proposed in this pull request:

Uses the color contrast utility to fix badge icon color on colored backgrounds.

Screenshot Screenshot from 2023-04-27 19-42-35

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)