fix(tags): `DiscussionTaggedPost` shows tags as `deleted` - Githubissues

flarum / framework

Simple forum software for building great communities.

http://flarum.org/

6.36k stars 835 forks source link

fix(tags): `DiscussionTaggedPost` shows tags as `deleted` #3812

Closed SychO9 closed 1 year ago

SychO9 commented 1 year ago

Fixes #3620

Changes proposed in this pull request:

Uses tag mentions table (which is already in the tags extension) to include tags used in a discussionTagged post event, so that they are present in the frontend store and properly rendered.
This will not fix older event posts, but will work for new ones.

Screenshot	Before	After (new event post) (authorized users to see the tag)	unauthorized users from seeing the tag

Necessity

[x] Has the problem that is being solved here been clearly explained?
[x] If applicable, have various options for solving this problem been considered?
[x] For core PRs, does this need to be in core, or could it be in an extension?
[x] Are we willing to maintain this for years / potentially forever?

Confirmed

[ ] Frontend changes: tested on a local Flarum installation.
[ ] Backend changes: tests are green (run composer test).
[ ] Core developer confirmed locally this works as intended.
[ ] Tests have been added, or are not appropriate here.

Required changes:

[ ] Related documentation PR: (Remove if irrelevant)
[ ] Related core extension PRs: (Remove if irrelevant)

luceos commented 1 year ago

👏